search

getgrav / grav-plugin-pagination

Grav Pagination Plugin
https://getgrav.org
MIT License
27 stars 20 forks source link

fix malformed pagination urls attempt #2 #36

Open gigago opened 6 years ago

gigago commented 6 years ago

The previous 'unfix' of pagination urls unfixed my application :-). Since the resulting urls are in fact malformed when base_url contains a scheme id and some browsers don't like this, let's try again to solve this in a different way by appending the filter |replace({':/':'://'}) to each url. Supposedly, this will only affect the scheme part of the url, if any.

juffalow commented 5 years ago

Your suggestion with |replace({':/':'://'}) fixed my problem. While this is not merged, the only solution is to create the pagination.html.twig file in my theme.

gigago commented 5 years ago

That's what I did too :-)

On 18/01/2019 12.38, Matej Jellus wrote:

Your suggestion with ||replace({':/':'://'})| fixed my problem. While this is not merged, the only solution is to create the |pagination.html.twig| file in my theme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/getgrav/grav-plugin-pagination/pull/36#issuecomment-455518228, or mute the thread https://github.com/notifications/unsubscribe-auth/AQShiX_PILagg56eekgMAOJfrKgaWPBDks5vEbJBgaJpZM4YSKxV.

juffalow commented 5 years ago

@gigago it is still not good :( Now the pages are with three /. Browser will fix it so it is working but when you check the source code, it is wrong. https://juffalow.com and the pagination on the bottom is https:///.

juffalow commented 5 years ago

Btw, for me, the previous version is working cfb8064c687f258508789764e2ca24ae80e3eebf.

gigago commented 5 years ago

My quick fix doesn't check the input url in any way. It just assumes the input url to be incorrect and also inserts a slash when the original url is correct. We'll need regex to solve this in a more robust way. https://twig.symfony.com/doc/2.x/templates.html#comparisons

On 22/01/2019 12.03, Matej Jellus wrote:

Btw, for me, the previous version is working cfb8064 https://github.com/getgrav/grav-plugin-pagination/commit/cfb8064c687f258508789764e2ca24ae80e3eebf.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/getgrav/grav-plugin-pagination/pull/36#issuecomment-456359809, or mute the thread https://github.com/notifications/unsubscribe-auth/AQShiQYa1vUqXAi5KWI6cFtzUL-1DYIMks5vFvABgaJpZM4YSKxV.