getgrav / grav-plugin-problems

Grav Problems Plugin
https://getgrav.org
MIT License
10 stars 8 forks source link

mod-rewrite false negative #10

Open Duke3D opened 7 years ago

Duke3D commented 7 years ago

The method of testing for mod-rewrite creates a false negative due to the testing method being used.
Suggest that either: a) The testing method be updated to solve the false negative or, b) Add an ability to ignore the specific error and proceed anyway, which sets a persistent configuration setting that disables the one test c) Add the ability for the user to select to disable Problems on the Problems page that causes the plugin to be disabled and the Problems page to not render again unless the plugin is re-enabled. b) Add text to the Problems page explaining how to manually remove the Problems plugin so they can continue on to reaching the Admin User Setup Screen on a properly functioning server, e) Add instructions for how and when to manually remove the Problems plugin to the Troubleshooting section of the user guide and a link to that Troubleshooting page on the Problems page.

flaviocopes commented 7 years ago

If there is a false positive, we can fix it if you describe your setup. The check is very simple, if using Apache and mod_rewrite is not in the modules list, we raise an issue. Do you have another scenario where mod_rewrite is not detected but you have it installed?

creopard commented 4 years ago

function apache_get_modules is used to detect mod_rewrite, but this is not reliable way, because this works only when PHP is installed as an Apache module. So it doesn't work with fastCGI, FPM or nginx configurations.

mahagr commented 4 years ago

 @creopard Do you have an idea how to make it reliably to work with the other configurations?

creopard commented 4 years ago

@mahagr I doubt there is a proper way to do it, see for instance: https://github.com/nette/examples/issues/17

mahagr commented 4 years ago

CC @rhukster