search

getgrav / grav-plugin-simplesearch

Grav SimpleSearch Plugin
https://getgrav.org
MIT License
44 stars 55 forks source link

Fix order of sprintf variables in french translation #114

Closed Lamecarlate closed 7 years ago

Lamecarlate commented 7 years ago

Use case: "vendée" is the searched term, "2" is the number of results.

Without the fix:

Recherche : vendée résultats trouvés pour 2

(litterally: "there is vendée results for the search of '2'")

With it:

Recherche : 2 résultats trouvés pour vendée

Maybe other languages need this fix too.

flaviocopes commented 7 years ago

Yes the fix is needed because as far as I can read through the other languages, the phrase is inverted. The other ones say "Searching for XXXX got X results"

flaviocopes commented 7 years ago

@MATsxm what do you think, better invert the phrase or accept the PR?

MATsxm commented 7 years ago

Sure thing.... consistency FTW! 😉 Thanks