search

getgrav / grav-plugin-simplesearch

Grav SimpleSearch Plugin
https://getgrav.org
MIT License
44 stars 55 forks source link

it seems the placeholder text is gone ? #119

Open JohnMica opened 7 years ago

JohnMica commented 7 years ago

Hi guys,

Just updated to the latest version and it seems that the placeholder no longer finds the proper string to display. As per the picture attached it stays to the {.......placeholder} captura de ecran din 2017 06 02 la 00 44 27

is this just me messing around or maybe an error with the plugin ?

thanks in advance

rhukster commented 7 years ago

There for me: https://github.com/getgrav/grav-plugin-simplesearch/blob/develop/languages.yaml#L3

JohnMica commented 7 years ago

i have the languages as well and they do look proper. still this strange glitch (cache disabled, local, mamp and codekit)

rhukster commented 7 years ago

Did you mess about with language files?

JohnMica commented 7 years ago

I havent - i just checked them out to make sure that everything is there. I have updated the content of .searchbox.html.twig to the latest version and now i get an updated HTML input with the same placeholder issue ... captura de ecran din 2017 06 02 la 00 56 11

rhukster commented 7 years ago

https://demo.getgrav.org/blog-skeleton/

Seems ok here:

2017-06-01 at 5 59 pm

JohnMica commented 7 years ago

i can see that = i'll replace my files completely and see if anything changes and i'll update this. thanks for the quick replies.

JohnMica commented 7 years ago

I have played with the files and cant seem to make it work. AS per the picture attached, the rezults do get the proper translation from the array but not the placeholder.

captura de ecran din 2017 06 02 la 01 04 56

since I cant figure it out, I have hardcoded the placeholder for now,

flaviocopes commented 7 years ago

@JohnMica you have translations enabled in the System configuration?

JohnMica commented 7 years ago

@FlavioCopes - translations are enabled and default language is Romanian. As you can see the results.html.twig picks up the translation just the placeholder doesn't really want to ... not sure why

flaviocopes commented 7 years ago

Do you have system.languages.translations_fallback enabled? I notice the string is not translated in romanian, so maybe it's not picked up for this reason. Otherwise, adding it to the ro translations should work

mxnr commented 7 years ago

Hey guys! I had the same issue, fixed it by switching languages: translations: false to translations: true. What make sense because in other way translations are not working.

eisenherzz commented 7 years ago

Seems that none of the placeholders get fillled. German translation is activated and the german strings look correct to me. snapshot1