getgrav / grav-plugin-simplesearch

Grav SimpleSearch Plugin
https://getgrav.org
MIT License
44 stars 55 forks source link

fixes a small bug and adds 2 hacks to allows parameters in url for a search #120

Closed LaurentOngaro closed 6 years ago

LaurentOngaro commented 7 years ago

fix: count and label order in the display of the results count in the result page

hack: allows direct use of the search page by specifying the filter t…o use in url parameters Sample use to search among tags: http://www.website.com/search/query;myword/filters;tag

hack: adds a parameter to show or not the search field and the number of results in search results page Example of use to search among tags: http://www.mywebsite.com/search/query;myword/showsearch;0

I'm using these hacks to replace tagcloud plugin's url because my website has a multi level blog and using the grav taxonomy doesn't permit searching through the multiple level of my blog. The solution I found was to use the simplesearch plugin with allowing filters to be passed in the url and not only in the settings

LaurentOngaro commented 7 years ago

Hi, I've reverted the change requested on the develop branch of my fork. But I don't what to do next to answer to your change request ? Should I close my PR and submit another one ?

flaviocopes commented 7 years ago

Thanks! All fine on your part, I just need to test

LaurentOngaro commented 7 years ago

Hi, Can you check if the code is good for you now and accept (or not) the PR ? thanks

rhukster commented 6 years ago

Lack of requested updates.... closing..