search

getgrav / grav-plugin-sitemap

Grav Sitemap Plugin
https://getgrav.org
MIT License
42 stars 42 forks source link

Alternative replacement for ignore:true, using visible or published #88

Closed pierrejoye closed 3 years ago

pierrejoye commented 3 years ago

Good evening,

Thanks you for this handy plugin!

Would it make sense to use either the visible or publish page properties instead of as a default alternative of sitemape: ignore: true?

I was only a little surprised to see unpublished or visible: false pages in the sitemap (I use a few to compose pages as well, include them from twig).

I can provide a PR if desired, to check either of these properties. What do you think?

rhukster commented 3 years ago

the page needs to be routable and published in order for it for it to be reachable by crawlers. visible is just to indicate if the page should be in the menu or not, so it's really not an appropriate setting to use. I think having a sitemap specific ignore is the best way.