search

getgrav / grav-premium-issues

Official Grav Premium Issues repository to report problems or ask questions regarding the Premium products offered.
https://getgrav.org/premium
7 stars 2 forks source link

[typhoon] Unable to disable modular menu in Typhoon skeleton/theme #264

Closed spencergoldade closed 2 years ago

spencergoldade commented 2 years ago

Problem Unable to disable modular menu in Typhoon skeleton/theme

User Story As a Typhoon user, I want to be able to start with the One-Page template but disable the modular menu, because it is just a great starting point for me and I don't necessarily want the one-page format.

Steps to Reproduce

  1. Install the Typhoon Skeleton
  2. Navigate to the settings for the Modular Homepage
  3. Under "Header Configuration" toggle on the override for "Modular On-Page Menu" and set toggle to "No"
  4. Save
  5. Setting reverts to this setting being off, unable to override

Notes I assume this may be due to a conflict between these settings and the page template.

rhukster commented 2 years ago

I can't recreate this:

CleanShot 2022-04-15 at 09 42 40@2x

The default menu state is to show the regular menu items. If i toggle the "Enable on-page menu" option in the modular page's "Advanced" tab. I can select either "Yes" or "No" and it retains the value between saves. Note that only "Yes" will toggle the on-page menu functionality, "No" is effectively the same as not setting it at all. You can confirm the behavior by clicking the "Expert" toggle in the tab bar and inspecting the YAML.

I have noticed that the default value is set to "Yes" when not enabled, and this should in fact be "No", and I've just fixed this for the next update.