getgrav / grav-premium-issues

Official Grav Premium Issues repository to report problems or ask questions regarding the Premium products offered.
https://getgrav.org/premium
7 stars 2 forks source link

[nextgen-editor] Line break in table cell #346

Closed newmedicine closed 1 year ago

newmedicine commented 1 year ago

I'm aware of the limitations of Markdown tables but is there a way of inserting a line break in a table cell?

I can enter a <br/> into a cell to create the line break, after which saving the page renders correctly, but if I save the page again (this time without a <br/>) the table "disintegrates".

Nextgen editor v1.1.13 Admin panel v1.10.39

duronflo commented 1 year ago

I encouter same behaviour but no answer so far for me :(

https://github.com/getgrav/grav-premium-issues/issues/333

newmedicine commented 1 year ago

Apparently nextgen-editor is probably going to be pulled permanently due to licensing disputes with CKSource


From: duronflo @.> Sent: 19 March 2023 15:43 To: getgrav/grav-premium-issues @.> Cc: Nick Bell @.>; Author @.> Subject: Re: [getgrav/grav-premium-issues] [nextgen-editor] Line break in table cell (Issue #346)

I encouter same behaviour but no answer so far for me :(

333https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgetgrav%2Fgrav-premium-issues%2Fissues%2F333&data=05%7C01%7C%7C924d7619638741ade61a08db2890b0ea%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638148374135407389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PR9mbIFp8aT%2BrCs2egd3dsQ2DxClQof14NVr%2B%2FsWROw%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgetgrav%2Fgrav-premium-issues%2Fissues%2F346%23issuecomment-1475297881&data=05%7C01%7C%7C924d7619638741ade61a08db2890b0ea%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638148374135407389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0S3p%2FGBF%2FM2h%2F5XoEW89%2BZwYXXJXYn%2Bo0a3A3jtUpeE%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFLHNY3Z6GM2BGRKT7ZDSODW44SSFANCNFSM6AAAAAAVRWUSLM&data=05%7C01%7C%7C924d7619638741ade61a08db2890b0ea%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638148374135407389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0hWroyrL1bcKT01gmiKdlObnoXiDUy1FLMRnM7zeK3I%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

w00fz commented 1 year ago

Apparently nextgen-editor is probably going to be pulled permanently due to licensing disputes with CKSource

This is no longer the case. We are in talks with CKSource and after we are done finalizing the paperwork, we will reintroduce NextGen to the Premium marketplace.


As for new lines in tables, unfortunately, this is just a limitation with markdown tables and our mechanism of handling the markdown to html back and forth is clearly not robust enough for this specific case. This case is particularly harder because Markdown only allows inline HTML elements within a table cell (links, bold, italic, etc), allowing any arbitrary HTML element means also allowing block elements, like in the case of #333 where an iframe is tried to be embedded.

It will require more investigation for a viable solution but I would suggest instead to go with a full HTML table instead (this is what we end doing often), as a markdown table is just extremely limited.

w00fz commented 1 year ago

I was able to get newlines (<br />) preserved in tables. This will solve the original reported issue. It will be available in v1.1.15 when we get it back into the marketplace.