search

getgrav / grav-premium-issues

Official Grav Premium Issues repository to report problems or ask questions regarding the Premium products offered.
https://getgrav.org/premium
7 stars 2 forks source link

[seo-magic] Meta image attribute is "seomagic-image" #360

Closed matt-j-m closed 1 year ago

matt-j-m commented 1 year ago

Hi there, running SEO Magic on latest Grav v1.7.40 - Admin v1.10.40.

No matter what selection I make for "Image Type" under "Meta Images" I end up with a value of "seomagic-image".

For example, if I set it to "The first image found in the current page's folder" then view my homepage in my local environment (which has many images in the page) the meta value comes out as <meta name="image" content="http://localhost/seomagic-image" />

I get the same output when I use the setting "Automatically pick a local image" or "Default URL of a specific image" with a "Default Image" value of "https://via.placeholder.com/1200x630/cccccc/969696"

Am I doing something wrong?

rhukster commented 1 year ago

Sorry back from vaction, i'll take a look at this as soon as possible.

rhukster commented 1 year ago

Ok, this is actually correct. The URL is always http://<your-site>/seomagic-image because this is a URL that proxies the image based on the configuration of the plugin. If you type this URL into your browser the resulting image shoud change based on your configuration.

matt-j-m commented 1 year ago

This is helpful, thank you. After further testing I realised it's working for every page except the homepage, on localhost. Once I deploy to the live server, it works on all pages, including the homepage.

In my local environment when I hit http://localhost/seomagic-image I get the following error:

Call to a member function media() on null

pointing to line 234 of user\plugins\seo-magic\classes\SEOMagic.php: $media = $page->media();