getgrav / grav-premium-issues

Official Grav Premium Issues repository to report problems or ask questions regarding the Premium products offered.
https://getgrav.org/premium
7 stars 2 forks source link

[seo-magic] Meta description generation and theme loaded CSS Body Selectors #378

Closed blizam closed 11 months ago

blizam commented 11 months ago

I can only get SEO Magic to generate automatic descriptions when the CSS selector specified in SEO Magic's settings is used directly in the page content... I basically have to have some HTML with the class in my body content or I have to specify a "Body class(es)" on the Advanced tab for the Page -- the latter is problematic because it loads in the obviously tag so ALL content is scanned, but it does work.

There's classes that the theme (Gantry - RT) is setting, like ".e-content" for example, that I would like to target but I can't get SEO Magic to target any class that isn't set specifically in the Page's .md file...

Maybe it's not possible for it to use CSS selectors outside of the page content... but maybe we could at least get an option for it to scan all the page content, as opposed/in-addition to using CSS selectors at all... I generally use HTML in my Page content anyways, but I do have some pure Markdown pages that I would be unable to have scanned (aside from a <body> class) presently.

I misunderstood what was really going on...

blizam commented 11 months ago

I should note too (seperate issue, my apologies, I can make a separate post) that I'm getting inconsistent descriptions generated... or more-so now that even when I use a selector in that's only in the Page content PHP.Science TextRank is scanning the entire page and building a description with a bunch of junk that's in the menu/header of the site... it WAS working correctly early in my testing with putting CSS selectors in the Page content directly... then I started playing with the Body classes and it seems like Textrank is "stuck" on scanning the entire body now when it detects the CSS selector anywhere on the page...

blizam commented 11 months ago

Yeah... I'm just gonna close this and make a new post... my bad... there's an issue but it aint this.

blizam commented 11 months ago

https://github.com/getgrav/grav-premium-issues/issues/380