getgrav / grav-premium-issues

Official Grav Premium Issues repository to report problems or ask questions regarding the Premium products offered.
https://getgrav.org/premium
7 stars 2 forks source link

[typhoon] Header height is somehow ignored wince latest typhoon update (2.4.4) #409

Closed lpbellerose closed 8 months ago

lpbellerose commented 8 months ago

Hi

I've lately updated the theme to the latest version (2.4.4) and somehow the tailwind height class for the header is not taken into account. The custom parameter from the admin is getting into the code alright, but when inspecting, it doesn't appear in the CSS. I've tried to clear the site's cache, but it didn't change anything.

You can see here: https://bellerosexd.com/en

The class is there in the HTML: image

The logo is currently at a H-6 height, but header should be h-12 (3rem) which it is currently not: image

Any idea?

rhukster commented 8 months ago

Yes, you need to recompile the CSS to pick up any new classes that were not picked up during the initial Typhoon CSS compile process.

Check out this section of the docs.

https://getgrav.org/premium/typhoon/docs#modify-the-css

If you want to be able to dynamically use some different clases you can put them in the available-classes.md file which sits in the root of the Typhoon theme folder. This is also checked for valid classes during the compile time, so it's a great place to put a variety of h-X classes that you might want end users to pick from without having to recompile the CSS every time.

lpbellerose commented 8 months ago

Thanks @rhukster, it took me a while debugging and getting everything ready to make the build. From what I can see, the h-12 was not used anymore, which is understandable, but for an admin type of user, it would be nice to have some gradation of heights, widths and so on to use whether or not it is used in the code so we can use it in the admin without going through all the npm process.

rhukster commented 8 months ago

Yah, the problem is there's so many heights that it wouldn't make much sense to add them all, as you would end up with much larger CSS than you would need, and that's one of the main benefits of tailwind. That's why I created this available-classes.md to let people put in a 'some' stuff that they might want to be able to change to in the admin. It's a comprimise I know.