search

getgrav / grav-skeleton-landio-site

Land.io is a carefully crafted landing page UI kit and landing page template built on Bootstrap 4, designed by Peter Finlan and developed by Taty Grassini.
https://getgrav.org
Other
24 stars 20 forks source link

Some issues after Grav v1.1.x update #6

Open grumero opened 8 years ago

grumero commented 8 years ago

Hi there,

This sceleton is not working as is. Users are forced to upgrade to Grav v1.1.x. Classes within markup are not working and show up on the rendered page. Instead of: ### Contact us {.text-center .m-b-lg} ) I had to use pure HTML: <h3 class="text-center m-b-lg">Contact us</h3>

For centering the contact-form also on medium format screens I added the class col-md-offset-2 to the corresponding divs.

Issue with the navigation: rightmost entry reads as LOGIN_PLUGIN.BTN_LOGIN. Seems there is some issue with fetching the variable value.

I did not get the contact form to send emails. Crosschecking my mail settings with another sceleton (ceevee) worked like charm. Have no clue how to solve this.

This is a great template and I'd like to use this, but I'd need to have this contact form working.

Best regards. Peter

rhukster commented 8 years ago

Did you download the package from the releases?

grumero commented 8 years ago

Hi. Yes I downloaded the skeleton from the releases here: https://getgrav.org/downloads/skeletons https://getgrav.org/downloads/skeletons The download button provided this link: https://github.com/getgrav/grav-skeleton-landio-site/releases/download/1.0.0/grav-skeleton-landio-site-v1.0.0.zip

Am 26.05.2016 um 14:06 schrieb Andy Miller notifications@github.com:

Did you download the package from the releases?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/getgrav/grav-skeleton-landio-site/issues/6#issuecomment-221852915

flaviocopes commented 8 years ago

Ok so, the skeleton is including Admin, but Admin 1.1 instead of the stable release. Should we drop including Admin? Must be the only skeleton doing this.

I tested the class on the h3. Works fine. You have a trailing ) that makes it not work.

I fixed the Landio theme form issue on medium screens.

I cannot find the LOGIN_PLUGIN.BTN_LOGIN string, can you make a screenshot? Did you add some twig edit?

The form worked fine for me, I got the email. Please use a testing SMTP service to test emails, don't rely on PHP mail() (which is the default of the email plugin, but not always works due to various reasons). See https://github.com/getgrav/grav-plugin-email#testing-emails

grumero commented 8 years ago

OK, I see. Here is what I am experiencing: Downloaded the skeleton and run it. As of the admin panel is newer than GRAV core I am get a message to upgrade to 1.1.x. message

But that's not working because setting 

gpm: 
   releases: testing

in the system.yaml is not working at this state. So I get: $ bin/gpm selfupgrade -f You are already running the latest version of Grav (v1.0.10) released on Thu Feb 11 22:37:50 2016 But in this state I can not get the admin panel running or create an user account.

To make it work with Grav 1.1.x I loadet the 1.1.5beta core + admin and copied the user folder from the skeleton in there. This was the only way I knew to get away from Grav 1.0.10

But than the classes within the markup do not render correct, as described before (my trailing ) was only a mistake in my first post as I copied this from the outcommented markup) classes classes2

The email function is also broken than and the thankyou page will not show up.

Today I did this: stayed at the Grav v1.0.10 and installed the older admin-panel to get it up and running with the given core. This way the email function is working fine ( I only ever use SMTP ) and the classes within markup rendered also fine.

But still there is this LOGIN_PLUGIN.BTN_LOGIN thing and I don't find where this value will be set. login button This shows up also for the login button. login2

Anyway, now I know how I can use your template with v.1.0.10 and that's fine as I don't need the user login right now. Maybe you could do the skeleton download yourself and try to get it up and running like a noob like me.

Hope I could bring some light into this and thanks for the quick reply.

flaviocopes commented 8 years ago

I did try this with the skeleton download,

Admin should not be included in the first place, that caused the other problems. @rhukster we should remove this, and recompile the skeleton? As it's getting Admin 1.1. Also now can include the landio theme update.

I can get the "Contact us" working. Make sure you enabled Markdown Extra in the config.

I fixed the language strings in the theme repository: https://github.com/getgrav/grav-theme-landio/commits/develop they were inverted.

grumero commented 8 years ago

You can get around this by installing the older admin plugin (uninstalling the version that came with the skeleton first) Also a view other issues are fixed in the development version of the theme, so you better get the stand alone theme and not the skeleton. Just my two cents.

flaviocopes commented 8 years ago

Just removed admin from .dependencies