Modular nav doesn't work when title is changed

getgrav / grav-theme-landio

Land.io is a carefully crafted landing page UI kit and landing page template built on Bootstrap 4, designed by Peter Finlan and developed by Taty Grassini.

https://getgrav.org

Other

31 stars 15 forks source link

Modular nav doesn't work when title is changed #8

Open olivierdalang opened 7 years ago

olivierdalang commented 7 years ago

Hi !

It seems the modular templates hardcode section ids while the nav generates links using the page title. This means the one page navigation breaks when page menu string is not the same than the hardcoded id.

In templates/modulars/news.html.twig :

<section id="news" class="section-news">

In intemplates/partials/navigation.html.twig` :

<a class="nav-link" href="#{{ _self.pageLinkName(module.menu) }}">{{ module.menu }}</a>