search

getgrav / grav-theme-learn2

Learn2 Grav Theme
https://getgrav.org
MIT License
80 stars 42 forks source link

Default template should exist #40

Open elmimmo opened 7 years ago

elmimmo commented 7 years ago

Pages created with the Admin plugin default to the Default template, yet Learn2 has no such template. Navigating to pages the template of which has not been explicitely set to a non-default one leads to an error:

400 - Template "default.html.twig" is not defined.

Learn2 should therefore provide a Default template.

flaviocopes commented 7 years ago

The Learn theme is a very custom theme that only works with docs and chapter page types, so it's not really supporting default page types. There probably should be a way for Admin to ask the theme what is the default page type, on the other hand.

elmimmo commented 7 years ago

Well, @mahagr at getgrav/grav-plugin-admin#447 said:

That makes default type a mandatory type -- you just cannot ignore it in theme.

😕

flaviocopes commented 7 years ago

Most themes do, Learn2 is a bit special.

Same as https://github.com/getgrav/grav-theme-learn2/issues/19