search

getgrav / grav-theme-learn2

Learn2 Grav Theme
https://getgrav.org
MIT License
80 stars 42 forks source link

"Off" option for GitHub position is not showing up in Grav Admin #47

Open rbukovansky opened 7 years ago

rbukovansky commented 7 years ago

It seems to me that "off" option for GitHub position is not processed correctly by Grav Admin and not shown in combobox. Can you do anything about it or should I log issue with Grav Admin directly? Thanks.

screen shot 2017-02-09 at 15 22 14

flaviocopes commented 7 years ago

I see it fine in the latest release. Tested the RTFM skeleton 🤔

screen shot 2017-02-09 at 18 36 00

rbukovansky commented 7 years ago

Not for me... Took actual plain RTFM-skeleton from getgrav.org, no changes, except bin/gpm install admin, update to Learn2 installed via Admin and that option is still not there... :thinking:

Fedora 25 Server Apache 2.4.25 PHP 7.0.15

Grav v1.1.15 Admin v1.2.10 Learn2 v1.6.3

flaviocopes commented 7 years ago

The user/themes/learn2/blueprints.yaml file contains the "Off" option?

rbukovansky commented 7 years ago

Yup... screen shot 2017-02-10 at 11 04 53

flaviocopes commented 7 years ago

If you change "off" to something else, does it work? Anyone else can replicate the issue?

rbukovansky commented 7 years ago

Yes, those two other options work just fine.

flaviocopes commented 7 years ago

I mean, if you change off: Off to offtest: Offtest for example, does it work? To check if it's the specific string causing the problem

rbukovansky commented 7 years ago

Changing it to offtest: Offtest works. Reverting back to off: Off doesn't.

ghost commented 6 years ago

I know I am a bit late, but @rbukovansky you can edit the yaml file in user/config/themes/learn2.yaml (make it if it doesn't exist) and add the following text:

top_level_version: false
home_url:
github:
    enabled: false
    position: off
    tree: https://github.com/getgrav/grav-skeleton-rtfm-site/blob/develop/
    commits: https://github.com/getgrav/grav-skeleton-rtfm-site/commits/develop/

Ensure that the text after position is off. There you go!