search

getgrav / grav-theme-learn2

Learn2 Grav Theme
https://getgrav.org
MIT License
80 stars 42 forks source link

Deactivate Googlefonts #99

Open RoundAboutWEB opened 2 years ago

RoundAboutWEB commented 2 years ago

The "Learn2" theme is great, but it uses Google fonts, which makes the pages warnable.

How can the fonts be replaced/changed?

sennewood commented 2 years ago

My Firefox console doesn't show any connnection to a google server if that is your concern. I'm using the docker variant of Grav if that is important.

RoundAboutWEB commented 2 years ago

The problem will be with the theme "Learn2" (and some other). With the theme "Quark" everything will be fine.

sennewood commented 2 years ago

I'm using Learn2.

RoundAboutWEB commented 1 year ago

Then you have changed something, because in the original fonts from Google are included:

grafik File: user/themes/learn2/scss/theme/_fonts.scss

sennewood commented 1 year ago

The docker variant uses the libfreetype6 package: https://github.com/getgrav/docker-grav/blob/master/Dockerfile#L12

Maybe the fonts that needs to be loaded are included there? I honestly don't know, but since I didn't change anything regarding fonts I guess it has something to do with docker.

In any case it would help if more people respond to this issue :)

eauchat commented 7 months ago

I'm also interested in fixing this issue. It would be easy to provide the fonts locally. Or at least to give the option to do so. Are you interested in a PR to address this issue? If so, I can write one.

Which approach would you prefer?

eauchat commented 7 months ago

For the record, this theme is based on learn2 with a few improvements, one of which being that in removes google fonts.