search

getgrav / grav-theme-photographer

Photographer Theme for Grav - Modern photography portfolio.
https://getgrav.org
MIT License
6 stars 12 forks source link

Portfolio modular section disappearing text #11

Open tpXander opened 2 years ago

tpXander commented 2 years ago

When working with this theme/skeleton, I noticed that the text for items inside a portfolio modular section disappears after navigating away and back to a page containing them. This issue appears to occur both on my site using the theme as well as the demo site for the skeleton.

To reproduce this issue: Navigate to https://demo.getgrav.org/photographer-skeleton/ See that the portfolio section is displayed properly: firefox_tfUVMbTsKA

Click "about me" or any other page in the menu, then click home to navigate back to the home page

See that the portfolio section is displayed with missing text: firefox_0xEVqvoC56

The text reappears if you reload the page or open the browser's developer tools, leading me to believe this may be a rendering issue, however, I have tested with Firefox, Chromium, and Edge on Windows 10, as well as Safari, Chrome, and Firefox on MacOS and the same issue occurs on every system I have tested.

Copied from https://github.com/getgrav/grav-skeleton-photographer-site/issues/10#issue-1208592185

tpXander commented 2 years ago

Removing line 30: {% do assets.addJs('theme://js/jquery.equalheights.js') %} from base.html.twig appears to fix this issue, although I don't know JS well enough to know if this is the proper fix to submit a pull request. Thanks to @OleVik for the suggestion and help here

OleVik commented 2 years ago

In general, a pull request can be quite general or quite specific. In GitHub, you can click the edit-button on the right from the file your found, remove the line, and GitHub will let you propose it as a change - make a pull request directly without the normal clone-process. That is the only practical change, and you can describe it as warranted because it fixes an issue by removing a script that appears superfluous. The repository's owner or managers will make sure the change, if it's merged, is included in the next release.

aixos commented 1 year ago

Removing line 30: {% do assets.addJs('theme://js/jquery.equalheights.js') %} from base.html.twig appears to fix this issue, although I don't know JS well enough to know if this is the proper fix to submit a pull request. Thanks to @OleVik for the suggestion and help here

Path: user/themes/photographer/templates/partials/base.html.twig

Hi, @tpXander The solution you mention seems to work for the moment greetings

Configuration: Grav v1.7.40 - Admin Panel v1.10.40 Email v3.2.0 Error v1.8.0 Flex Objects v1.3.4 Form v7.1.2 Login v3.7.3 Problems v2.1.1