search

getgrav / grav-theme-quark

MIT License
64 stars 57 forks source link

Markdown not processed in checkbox #161

Open NicoHood opened 3 years ago

NicoHood commented 3 years ago

I recently noticed, that checkbox form fields are not process, even when markdown is enabled.

There was a PR merged that fixes this: https://github.com/getgrav/grav-plugin-form/pull/233

But the theme overrides this template here: https://github.com/getgrav/grav-theme-quark/blob/develop/templates/forms/fields/checkbox/checkbox.html.twig

Now I am wondering, why does this template even exist? Should we fix it, or should we remove it?

Here is a diff of the current files, to quickly visualize it: Screenshot from 2020-09-28 11-11-56

NicoHood commented 3 years ago

Browsing through the History it looks like the checkbox (and possibly other field overrides) are missing a lot of the recent fixes. The only real difference I see here is the addition of <i class="form-icon"></i> before the field label. And this icon is used to display the checkboxes (the box, the rectangle) itself.

I guess the checkbox template can be completely removed then?

Edit: No, it cannot be removed yet, but the templates can be improved a lot. I've updated them here: https://github.com/NicoHood/grav-theme-quark/tree/magerquark

aricooperdavis commented 2 years ago

I'd like to see this fix in the next update - it seems a shame to have to overwrite it in a child theme.

kees-closed commented 1 year ago

I'd like to see this fix in the next update - it seems a shame to have to overwrite it in a child theme.

I agree, maybe @NicoHood can create a pull request? Or maybe outline what's needed to fix this, then maybe I can create a pull request based on that info.

kees-closed commented 1 year ago

Edit: No, it cannot be removed yet, but the templates can be improved a lot. I've updated them here: https://github.com/NicoHood/grav-theme-quark/tree/magerquark

I see you have many contributions in your own fork, could you please merge them with upstream? Thanks!

NicoHood commented 1 year ago

I posted a lot PRs, but it doesnt seem anybody cares about this theme.

kees-closed commented 1 year ago

Hi @rhukster, sorry to tag you in this thread. But it seems some very useful additions for this theme are not merged yet. Is it possible to review and merge them by someone from the Grav team?