search

getgrav / grav-theme-woo

Woo is a clean, modern, landing page site template. It has a fully responsive design and was tested on all major browser and mobile devices. Woo is the perfect template to showcase your apps, services or digital goods.
https://getgrav.org
Other
16 stars 8 forks source link

Fix social items in footer.html.twig #10

Open yagmuraras opened 5 years ago

yagmuraras commented 5 years ago

Formats you used in footer.html.twig and social.html.twig were different. footer.html.twig: <li><a href="{{ item.url }}">{{ item.icon|capitalize }}</a></li>

social.html.twig: <li><a href="{{ item.url }}"><i class="fa fa-{{ item.icon }}"></i></a></li>

I assumed footer's twig was incorrect and fixed accordingly.

yagmuraras commented 5 years ago

Note: I forgot to mention the reason I did this change.

Assuming the user chooses standart font-awesome icons fa-facebook fa-twitter fa-instagram etc. everything works as intended since icon names are capitalized into words. However, those are not the only social media icons and in fact they are the less used ones as far as I see.

There are ones like fa-facebook-square, fa-facebook-messenger, fa-facebook-f, fa-twitter-square, fa-linkedin-in, fa-google-plus-square, fa-google-plus-g, fa-google-play and many more goes like this. Choosing one of these as icons result in weird footer texts. So I guess using icons instead of text in footer would be much more suitable.

Those who have technical knowledge can still configure the site.yaml and footer twig to have texts instead of icons but those without enough technical knowledge might not be able to fix the weird texts in footer in current format.

Still, this is just a suggestion though. Thanks for your work!