Bug with embetty - Githubissues

huggenknubbel commented 6 years ago

I installed an embetty-server and implement this into Grav. now i create a new site and insert different tweets and some text. The text above the first tweet will shown but nothing below. i can't also find some of my text in the source code of the site.

Howto reproduce: install a embetty server (or deploy a docker server) insert the "header" tags

create a new site and enter follow content:

some text
<embetty-tweet status="950371792874557440"></embetty-tweet>
more text
<embetty-video type="youtube" video-id="3L4fHrIJ3A4"></embetty-video>
more more text
<embetty-video type="vimeo" video-id="223099532"></embetty-video>
more, more more text
<embetty-video type="facebook" video-id="10156049485672318"></embetty-video>
more text, just for debugging

the source code of the rendered website looks like as if it had been cut off below the first tweet:

<body id="top" class="">
--
   <div id="sb-site">
   <header id="header">
   <div class="logo-surround">
   <a href="/de" id="logo"></a>
   <span class="logo-accent"></span>
   </div>
   <div id="navbar">
    
   <ul class="navigation">
   <li class="">
   <a href="/de">
   Huggenknubbels Blog
   </a>
   </li>
   <li class="">
   <a href="https://knubbel.me/impressum">
   Impressum
   </a>
   </li>
   </ul>
    
   <span class="panel-activation sb-toggle-left navbar-left menu-btn fa fa-bars"></span>
   </div>
   </header>
   <section id="body">
   <p>some text</p>
   <embetty-tweet status="950371792874557440"></embetty-tweet>
   </section>
    
   <footer id="footer">
   <p><a href="http://getgrav.org">Grav</a> was <i class="fa fa-code"></i> with <i class="fa fa-heart"></i> by <a href="http://www.rockettheme.com">RocketTheme</a>.</p>
   </footer>
   </div>
   <div class="sb-slidebar sb-left sb-width-thin">
   <div id="panel">
    
   <ul class="navigation">
   <li class="">
   <a href="/de">
   Huggenknubbels Blog
   </a>
   </li>
   <li class="">
   <a href="https://knubbel.me/impressum">
   Impressum
   </a>
   </li>
   </ul>
    
   </div>
  </div>
  <script>
  $(function () {
  $(document).ready(function() {
  $.slidebars({
  hideControlClasses: true,
  scrollLock: true
  });
  });
  });
  </script>
  </body>
  </html>

rhukster commented 6 years ago

Is this really a Grav bug? Grav is file based so if embetty can't output the correct file structure then it's not going to work. I don't see what we could possible do here that we are not already doing?

huggenknubbel commented 6 years ago

yes i think so beceause if it wasn't a Grav Bug i got the emetty tags in the source code?

Am Do., 31. Mai 2018 um 22:47 Uhr schrieb Andy Miller < notifications@github.com>:

Is this really a Grav bug? Grav is file based so if embetty can't output the correct file structure then it's not going to work. I don't see what we could possible do here that we are not already doing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/getgrav/grav/issues/2042#issuecomment-393674462, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7hcL3FJKAZ6LVVFSt4CjnE-gm3kubnks5t4FbygaJpZM4UTRoS .

getgrav / grav

Bug with embetty #2042