getgrav / grav

Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS powered by PHP, Markdown, Twig, and Symfony
https://getgrav.org
MIT License
14.4k stars 1.39k forks source link

Languagecode bug #2048

Open w3suli opened 6 years ago

w3suli commented 6 years ago

Bad native name grav/system/src/Grav/Common/Language/LanguageCodes.php

bad version:

'sk'         => [ 'name' => 'Slovak',                    'nativeName' => 'Slovenčina' ],
'sl'         => [ 'name' => 'Slovenian',                 'nativeName' => 'Slovensko' ],

good version:

'sk'         => [ 'name' => 'Slovak',                    'nativeName' => 'Slovenský' ],
'sl'         => [ 'name' => 'Slovenian',                 'nativeName' => 'Slovenčina' ],
drnasin commented 6 years ago

Actually your 'bad version' of slovenian is right. We use two versions slovensko and slovenščina which means your 'good' version is wrong 😁

smz commented 6 years ago

Shouldn't it be Slovak -> Slovenčina and Slovenian -> Slovenščina (Slovensko being the country name, not the language name)?

w3suli commented 6 years ago

Hm google translate:

English-Slovak Slovak language: Slovenský jazyk english-slovenian Slovenian language: Slovenski jezik

I used the word Slovenský so far in Slovak.

drnasin commented 6 years ago

Slovenščina (Slovene language) is a noun, while slovensko is an adjective (so is "slovenski") as in "slovenski jezik" = slovenian language...so if we are changing yours might as well change ours to "Slovenščina"...to be a noun...

rhukster commented 6 years ago

I don't speak the language so really have no opinions. Ws there any consensus on this???

w3suli commented 6 years ago

I went after him :).

Slovak => Code: sk, Country: Slovensko, Language: Slovenský Slovak University of Technology in Bratislava (Move the mouse over SK.)

Slovenian => Code: si, Country: Slovenija, Language: Slovenščina University of Ljubljana (At the right of the search box)

drnasin commented 6 years ago

@w3suli Language: Slovenščina ..you are missing a letter...

Screenshot

w3suli commented 6 years ago

Sorry a letter missed.

I've upgraded the post. That's right.