adding '@2x' to images prevents removal from page media

getgrav / grav

Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS powered by PHP, Markdown, Twig, and Symfony

https://getgrav.org

MIT License

14.58k stars 1.41k forks source link

adding '@2x' to images prevents removal from page media #2100

Closed MattAppleton closed 6 years ago

MattAppleton commented 6 years ago

I haven't noticed this issue before, perhaps it is a new bug in 1.5.0 (beta2) and associated admin plugin?

Essentially I can successfully add and re-order images in page-media for a given project, (https://gresfordarchitects.co.uk/projects/chieveley) but when using the admin panel I am unable to delete a file, there is a red error note that comes up saying

unlink() not supported for read-only stream wrappers

MattAppleton commented 6 years ago

After a bit of troubleshooting it seems that the '@2x' that we typically append to image names for retina-ready reasons is the culprit here...

if I add an image that DOESNT have this filename ending, image removal works fine...

rhukster commented 6 years ago

will look into this matt. cheers.

rhukster commented 6 years ago

confirmed.. we're looking into it...

rhukster commented 6 years ago

Fixed in admin plugin

MattAppleton commented 6 years ago

Amazing! thanks as ever...