getgrav / grav

Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS powered by PHP, Markdown, Twig, and Symfony
https://getgrav.org
MIT License
14.48k stars 1.4k forks source link

Cleaning up Broken Themes #3405

Open xer0-1ne opened 3 years ago

xer0-1ne commented 3 years ago

Most of the themes available (in the Grav theme download section) break Grav. Most of these themes are abandon projects from GitHub yet these themes that are still listed in the Grav theme downloader. Is there a way to clean/purge these themes so that the list is a more accurate depiction of functional themes?

rhukster commented 3 years ago

Most likely there are a few minor bugs. Fundamentally Grav has not changed since its initial version. The beauty of open source is that if something has been abandoned, it can be forked and maintained again. I think a better first step would be to create a list of all themes and highlight any particular issue a theme is having, then look for people that might take on the job of fixing them.

mahagr commented 3 years ago

Also check out this document: https://learn.getgrav.org/17/advanced/grav-development/grav-17-upgrade-guide

Basically it should have all the breaking (and deprecated) changes listed for both themes and plugins.

hughbris commented 2 years ago

I think Andy's suggestion is worthwhile for someone who wants to take it on. However, it's a significant exercise to undertake. Might be best done as a coordinated push, I don't know.

Meantime, I think it's a poor experience for developers who are trying out Grav to be confronted with these errors from an official repository, trivial as they may be to fix.

Would you consider adding a note to the descriptions at the top of the download categories on the Downloads page, including a link to the upgrade guide Matias links above?

Long term it might be worth building in a filter for version compatibility, which could be sourced from a mandatory .dependencies file. I think some CMSs do this already.

gizmecano commented 2 years ago

Long term it might be worth building in a filter for version compatibility (...)

👍

Indeed, I think that a feature of this type would be very valuable.