search

getgrav / grav

Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS powered by PHP, Markdown, Twig, and Symfony
https://getgrav.org
MIT License
14.58k stars 1.41k forks source link

No easy way to know theme compatibility, some offered themes are obsolete #3486

Open counterpoint opened 3 years ago

counterpoint commented 3 years ago

Someone installing Grav afresh may want to install extra themes. The "Add" function shows a list of themes in alphabetical order. There is no indication of which themes are compatible with the current version of Grav. In fact, the first two themes shown are incompatible with current Grav, and are almost certainly obsolete and unsupported. A lot of time can be wasted attempting to find out which themes are even worth considering. It should be easier to select only compatible themes, and themes without current support should be removed.

rhukster commented 3 years ago

If you follow the guide to enable twig compatibility: https://learn.getgrav.org/17/advanced/grav-development/grav-17-upgrade-guide#twig

then all themes should work fine.

ghost commented 3 years ago

I agree with @counterpoint. It's confusing for new users to have broken themes presented with no indication of compatibility. I have only been using Grav a short time but already there have been 2 posts on the forum from people asking why themes don't work. I realise they can be fixed by editing yaml files but this is in the "advanced" section of the docs and we are talking about first time users. The natural tendency is to load up Grav then immediately check out a few different themes.

The simplest solution would be to add a line at the top of the "available themes" page saying that not all themes may be compatible with this version and giving the link to fix.

counterpoint commented 3 years ago

Thanks @rhukster but if you are referring to the auto escape fix, it isn’t sufficient to make Aerial (the first theme offered) work. In fact the demo site no longer exists, and the theme is unchanged for 6 years. Surely, if Grav is to be usable by most people, it should not offer themes that do not work without needing to edit files using knowledge that isn’t readily obtained.

pamtbaau commented 2 years ago

I have created discussion topic Theme repository cleanup and quality control and gave some suggestions to go forward. Your feedback is welcome.