getgrit / gritql

GritQL is a query language for searching, linting, and modifying code.
https://docs.grit.io/
MIT License
3.17k stars 82 forks source link

fix: 485 allow invalid extensions #562

Closed Alex-ley-scrub closed 3 weeks ago

Alex-ley-scrub commented 4 weeks ago

/claim #485

fixes #485

Greptile Summary

This is an auto-generated summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

Alex-ley-scrub commented 4 weeks ago

The iteration order over the files isn't stable/consistent so I'll need to change my snapshot test not to use 3 files at once: https://github.com/getgrit/gritql/actions/runs/11508722345/job/32037478385?pr=562#step:9:1068

Snapshot Summary ``` ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ error: test failed, to rerun pass `-p marzano --test apply` Snapshot file: crates/cli_bin/tests/snapshots/apply__apply_to_path_with_invalid_python_extension.snap Snapshot: apply_to_path_with_invalid_python_extension Source: crates/cli_bin/tests/apply.rs:2940 ──────────────────────────────────────────────────────────────────────────────── Expression: stdout ──────────────────────────────────────────────────────────────────────────────── -old snapshot +new results ────────────┬─────────────────────────────────────────────────────────────────── 0 │+file1.py 1 │+ -class MyClass(object): ... 2 │+ +class MyClass(): ... 3 │+ 4 │+ 5 │+file2.pyi 6 │+ -class MyClass(object): ... 7 │+ +class MyClass(): ... 8 │+ 9 │+ 0 10 │ file3.nopy 1 11 │ -class MyClass(object): ... 2 12 │ +class MyClass(): ... 3 13 │ 4 14 │ 5 │-file2.pyi 6 │- -class MyClass(object): ... 7 │- +class MyClass(): ... 8 │- 9 │- 10 │-file1.py 11 │- -class MyClass(object): ... 12 │- +class MyClass(): ... 13 │- 14 │- 15 15 │ Processed 3 files and found 3 matches ────────────┴─────────────────────────────────────────────────────────────────── ```
Alex-ley-scrub commented 3 weeks ago

@morgante do these bounties get auto awarded once the linked PR merges or not exactly? (This one hasn't yet)

I thought your slash command comment on the issue might automate it but it doesn't seem to have:

https://github.com/getgrit/gritql/issues/485#issuecomment-2436478318

/assign @Alex-ley-scrub

morgante commented 3 weeks ago

@Alex-ley-scrub No unfortunately I need to manually pay out each bounty.