getguesstimate / guesstimate-app

Create Fermi Estimates and Perform Monte Carlo Estimates
http://getguesstimate.com/
MIT License
2.34k stars 125 forks source link

NextJS and other improvements #1024

Closed berekuk closed 8 months ago

berekuk commented 1 year ago

Seems like this will to be a typical epic branch with a mix of many big refactorings.

This branch is still unstable and unfinished. I'm unsure which parts are unstable because of existing bugs (e.g. because of #1011) and which parts were broken by the upgrade. I'm still in the process of figuring out how everything works.

Stabilizing this PR is the first priority, but while I'm jumping around the codebase and poking my dev frontend instance, I might do some additional refactorings when it matches the current frontend best practices (e.g. functional components instead of classes), or when the change is safe and local enough.

I promise not to do any significant product-level changes here, though. (Might throw in some minor stuff that's relevant for debugging, e.g. nprogress or better error reporting).

netlify[bot] commented 1 year ago

Deploy Preview for guesstimate failed.

Name Link
Latest commit dd3117523d3f5f37adf3dad747388533ee389893
Latest deploy log https://app.netlify.com/sites/guesstimate/deploys/640d1be01cc7d90008cf6cd4
Incognito commented 1 year ago

I don't maintain this project but... Just a thought: Prettier makes no factual code changes but updates several hundred files, making the meaningful diffs harder for humans to find and read. Could easily be done in stand-alone PR first.

berekuk commented 1 year ago

@Incognito I agree in theory, but in practice this doesn't seem to matter in this specific case:

OAGr commented 1 year ago

@Incognito I just wanted to say, thanks for the comment, and we are really appreciative of suggestions, even when we don't wind up taking action on them. @berekuk ultimately makes calls here.

berekuk commented 8 months ago

Superseded by #1035.