search

getherbert / herbert

The WordPress Plugin Framework:
http://getherbert.com/
634 stars 95 forks source link

Relative symlinks break deployment #153

Closed jan-koch closed 5 years ago

jan-koch commented 7 years ago

Hey, first of all, thanks for putting all this work into Herbert. I love it!

Just tried it with DeployHQ, but it seems that relative symlinks are breaking the deployment. The SFTP user I use for deployment is chrooted, which should be the case for most web hosting environments.

Using absolute symlinks is no option, as every hosting environment is different. Using non-chrooted SFTP users won't work for most web hosts either.

Just wondering how to solve this or whether I'm missing something :-)

Looking forward to hearing your thoughts on this question.

Best, Jan

jeremyzahner commented 7 years ago

@jan-koch Hey Jan!

Thanks for using herbert. Could you elaborate a little further how exactly you are deploying? And could you provide logs etc.

jan-koch commented 5 years ago

Hey @jeremyzahner , sorry for ignoring this issue for such a long time. I have moved from herbert to wppb.me for plugin dev, so I'll close this issue here. Cannot say if it still persists :-/

Thanks for your work!

Best, Jan