search

getherbert / herbert

The WordPress Plugin Framework:
http://getherbert.com/
634 stars 95 forks source link

Allow CORS Requests #161

Closed ken-bem closed 7 years ago

ken-bem commented 7 years ago

I can't submit a pull request to add CORS to the framework, I get a 403 error, anyone who may be able to help?

jeremyzahner commented 7 years ago

@ken-bem I can see you've submitted the PR.

ken-bem commented 7 years ago

@jeremyzahner is the any way i can become a contributor with herbert?

jeremyzahner commented 7 years ago

@ken-bem You'll be a contributor as soon as one of your pull requests gets merged. =)

ken-bem commented 7 years ago

@jeremyzahner if i make a pull request, will someone at least look at it? because i made one 3 months ago on the framework itself and nobody accepted/rejected it

jeremyzahner commented 7 years ago

@ken-bem Promised. ;-) I also added a reaction to your last one just now.

ken-bem commented 7 years ago

@jeremyzahner I updated my pull request, if you could check it out i would appreciate it