Open giomf opened 1 month ago
Thanks for sharing the detailed information. I've released a fix in v0.27.1. Feel free to reopen this issue if needed.
Thanks the described issue seems to be fixed. Unfortunately, I have to re-open the issue again.
The link handling is still broken. However, it now affects basic links.
I get the following error:
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.presseportal.de/blaulicht/pm/82522/5885224' at 'einsaetze/2024/0009/index.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.ionos.de' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.ionos.de/terms-gtc/terms-privacy;' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.ionos.de/hilfe/datenschutz/allgemeine-informationen-zur-datenschutz-grundverordnung-dsgvo/auftragsverarbeitung' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.instart.com' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.instart.com/company/legal/privacy-policy' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/datenschutz-generator.de' at 'datenschutz.md'
ERROR partial [assets/link.html] - Cannot find page or asset: 'https:/www.presseportal.de/blaulicht/pm/82522/5877457' at 'einsaetze/2024/0007/index.md'
Here is one example how I create the links:
[Pressebericht](https://www.presseportal.de/blaulicht/pm/82522/5885224)
Edit: I dont know why, but I can not re-open this issue. Ping me if I should create another Issue
I fixed an error cleaning the link's url: https://github.com/gethinode/hinode/pull/1269/files#diff-02697a4d5bc59d090e9862b2de6e38349ad55396d0f1625175974c0bcb7e5491
The following example works as expected on my machine now (both Hinode and template repo):
[Pressebericht](https://www.presseportal.de/blaulicht/pm/82522/5885224)
The fix has been released in v0.27.3.
Hey,
thanks for you effort. The Links are working again! But still have some problems left. Now email adresses are failing...
ERROR partial [assets/link.html] - Cannot find page or asset: 'mailto:xxxx@yyyy.zz' at 'kontakt.md'
I do not use any shortcode ore markdown syntax. Its just a email in a page.
thanks for you effort. The Links are working again
Great!
Regarding the mailto issue, what is the exact input? The following input seems to render as expected:
[Mail](mailto:xxxx@yyyy.zz)
Sorry for beeing unclear.
The input is a simple email adress: xxxx@yyyy.zz it will be converted to the mailto form as it looks. At least that's what I interpret from the error message as I didn't specify the mailto in my input.
@markdumay Could you reproduce the issue? Im still not able to build the page.
Have you tried my example? I don't think leaving the mailto:
prefix is valid Markdown syntax...
[Mail](mailto:xxxx@yyyy.zz)
Hey,
no, not yet. But I think we're talking about different things. I don't use a mailto prefix. See here what im actually doing.
So basicly I just use an plain email address. I acutally dont want to use a named link here because I want that the users can still see the address.
Got it, thanks for the clarification. I copied the example input to a test page. It does not give any build errors... I'm using the following gold mark configuration in markup.toml
.
[goldmark]
[goldmark.extensions]
definitionList = true
footnote = true
linkify = true
strikethrough = true
table = true
taskList = true
typographer = true
[goldmark.extensions.passthrough]
enable = true
[goldmark.extensions.passthrough.delimiters]
block = [['\[', '\]'], ['$$', '$$']]
inline = [['\(', '\)'], ['$', '$']]
[goldmark.parser]
autoHeadingID = true
autoHeadingIDType = 'github'
wrapStandAloneImageWithinParagraph = false
[goldmark.parser.attribute]
block = true
[goldmark.renderer]
hardWraps = false
unsafe = false
xhtml = false
My suggestions:
[info@ff-eppendorf.de](mailto:info@ff-eppendorf.de)
). This syntax would still show the address to the user.If these suggestion don't help, I could clone a copy of your site to recreate your issues locally. Which branch should I use?
Thanks for the suggestions.
I have updated the goldmark config and also used the named link syntax. Unfortunalty without success.
It seems that every link not starting with http(s)://
are treated as page or asset.
Deactivating the Hinodes link handler seems odd. Also I dont know how to do it.
Yes, for sure you could have a look. Just take the master branch. But be aware that there are a lot of images and the repo is kind of big. Also im unexpiered with hugo. If you stumble accross some anit-pattern feel free to point them out to me.
Describe the bug
A link to a page ressoruce is not working anymore after updating from 24.x to 27.0. I know that 26.x introduced some changes regarding link handling. However, the documentation still says that it is possible to link to page ressources.
Unfortunately, I get this error when trying so:
How I create the link:
To reproduce
Steps to reproduce the behavior:
Expected behavior
It should still build and the links should be created.
Host environment
Please complete the following information where applicable.
Hugo environment
Copy the output of
hugo env
ornpm run env
here.Additional context
Add any other context about the problem here.