Fix/handle null id in json rpc responses and cpu load representation for openwrt widget

LiranV commented 4 months ago

Proposed change

Issue:

I've configured the OpenWRT widget in my homepage container, but saw the following:

initial-state

Tested on:

Homepage v0.8.13 and master
OpenWrt 23.05.0

The service configuration I've used:

    - OpenWRT:
        icon: openwrt.png
        widget:
          type: openwrt
          url: https://10.0.0.138
          username: homepage
          password: ********

Explanation:

The widget starts by issuing an unauthorized request to OpenWRT, which for some reason results with a response id that is null (according to the JSON-RPC 2.0 specification this is discouraged) and it seems to not play nice with the json-rpc-2.0 package)

{
    "jsonrpc": "2.0",
    "id": null,
    "error": {
        "code": -32002,
        "message": "Access denied"
    }
}

My first commit solves this issue by checking if the response id is null and setting it as 1 instead. This solves the issue and the widget starts working:

null-id-fix

Additional Fix:

After the widget started working I've noticed that the CPU Load number was "off" and didn't look like the standard UNIX load format expected by something like uptime. To solve this I've added the following calculation according to this:

The values in load are the load averages over 1, 5, and 15 minutes. to get to the familiar values reported by uptime divide these numbers by 65536.0 and round to 2 decimals.

After fixing CPU load representation: cpu-load-fix

Type of change

[ ] New service widget
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation only
[ ] Other (please explain)

Checklist:

[ ] If applicable, I have added corresponding documentation changes.
[ ] If applicable, I have reviewed the feature and / or service widget guidelines.
[x] I have checked that all code style checks pass using pre-commit hooks and linting checks.
[ ] If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

shamoon commented 4 months ago

I have no way to test or verify this and I dont know if anyone else has reported. @DanGRT ?

github-actions[bot] commented 3 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

gethomepage / homepage