Fix: Sort truenas pools by name

marktitorenkov commented 3 months ago

Proposed change

Sort truenas pools by name

Type of change

[ ] New service widget
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation only
[ ] Other (please explain)

Checklist:

[x] If applicable, I have added corresponding documentation changes.
[x] If applicable, I have reviewed the feature and / or service widget guidelines.
[x] I have checked that all code style checks pass using pre-commit hooks and linting checks.
[x] If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

shamoon commented 3 months ago

I realize it’s one line but did anyone request this? See https://gethomepage.dev/latest/more/development/#new-feature-guidelines as you checked off above

marktitorenkov commented 3 months ago

I was thinking of it more as a bugfix than a feature. Because it is the sort order used in the TrueNAS UI.

marktitorenkov commented 3 months ago

Thanks.

github-actions[bot] commented 2 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

gethomepage / homepage