Fix: don't show "partial" for k8s status if there are completed job pods

[charlesthomas]

i'm using a kubernetes service that includes a web UI and cronjobs. because the job finish and go to status Completed, the homepage link to the web UI shows partial instead of running

this patch updates the someReady & allReady pod filter to include pods that are both Running and Completed

Proposed change

Closes # (issue)

Type of change

• [ ] New service widget
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Documentation only
• [ ] Other (please explain)

Checklist:

• [ ] If applicable, I have added corresponding documentation changes.
• [ ] If applicable, I have reviewed the feature and / or service widget guidelines.
• [ ] I have checked that all code style checks pass using pre-commit hooks and linting checks.
• [ ] If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

My bad for not checking this more carefully, but FYI in is not the correct way to do this, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/in

[shamoon]

Also, apparently it doesn’t work either https://github.com/gethomepage/homepage/discussions/3759

I can only assume this wasn’t tested before submitting, and I know I didn’t because I don’t really have a real k8s setup so that’s on me, but I would recommend testing things out before submitting a PR in the future.

[github-actions[bot]]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.