Fix: wg-easy widget show o.filter is not a function when wg-easy api return error

gethomepage / homepage

A highly customizable homepage (or startpage / application dashboard) with Docker and service API integrations.

https://gethomepage.dev

GNU General Public License v3.0

18.73k stars 1.1k forks source link

Fix: wg-easy widget show o.filter is not a function when wg-easy api return error #3768

Closed BugGeeker closed 2 months ago

BugGeeker commented 2 months ago

Proposed change

Closes #3658

Type of change

[ ] New service widget
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation only
[ ] Other (please explain)

Checklist:

[x] If applicable, I have added corresponding documentation changes.
[x] If applicable, I have reviewed the feature and / or service widget guidelines.
[x] I have checked that all code style checks pass using pre-commit hooks and linting checks.
[x] If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

shamoon commented 2 months ago

What does wg-easy actually return in this case?

BugGeeker commented 2 months ago

What does wg-easy actually return in this case?

shamoon commented 2 months ago

Right, so instead of checking for an array, please change it to check the statusCode

Perhaps more importantly, why is your wg-easy throwing an error 500?

BugGeeker commented 2 months ago

Right, so instead of checking for an array, please change it to check the statusCode

Perhaps more importantly, why is your wg-easy throwing an error 500?

I make a commit to change the check method.

I don't know why wg-easy throwing 500, It's normal on wg-easy webui.

shamoon commented 2 months ago

Thanks. And please revert the unrelated change

BugGeeker commented 2 months ago

done.

github-actions[bot] commented 1 month ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.