Closed ping-localhost closed 1 month ago
Well, you need to change both of those things, that's why we have the guidelines.
I've removed the two lowest priority fields for now.
Im certain the existing jsonrpc proxy can be modified to accept body params, or just simply adding logic to use widget.key if its supplied instead of username/pw.
I've tried to do that, by passing the params via the URL itself and then parsing it again within the proxy. Hopefully this is okay.
We now also pass the actual widget
object to the sendJsonRpcRequest
so we can decide if we need to use username + password or the key.
Setting up a Zabbix instance to test does not seem trivial
If you're using Proxmox, you could use tteck's proxmox scripts to setup a Zabbix LXC.
As long as Authorization
stays capitalized, I'm happy with the changes in 4a0b18b. Zabbix doesn't accept the API token if the header is authorization
.
Perfect, thank you for fixing my mistake. I'll make sure to do better on the next widget 😁
So is this widget usable at this time? I set it up but getting this:
So is this widget usable at this time? I set it up but getting this:
There is no new release yet, so it is not available yet.
Ok, thanks for letting me know...
@adm2k FYI, the widget is now available
Thanks, working now...
Proposed change
The user will be able to add the widget to the
services.yaml
file using the following configuration:Relevant feature request: https://github.com/gethomepage/homepage/discussions/1953
Notes
I did somewhat break the Service Widget Guidelines.
auth
-field in the JSON RPC call for API tokens, which I could not figure out how to do with the generic jsonrpc proxy.Let me know what I should change to have a valid pull request.
Type of change
Checklist: