search

gethugothemes / dot-hugo

Dot - Hugo Documentation Theme
https://gethugothemes.com/products/dot/?utm_source=dot_github&utm_medium=referral&utm_campaign=github_theme_about
MIT License
261 stars 148 forks source link

Extra space added after line using icon within paragraph #159

Closed cacsfre closed 3 years ago

cacsfre commented 3 years ago

Here's an odd thing that happens when I use a fontawesome icon :

Screen Shot 2021-01-20 at 14 56 04

I don't see any line break in the source code though : 

<h5 id="paragraph">Paragraph</h5>
<p>Lorem ipsum dolor sit amet consectetur <a href="https://github.com/themefisher/dot-hugo-documentation-theme" target="_blank"><i class="fas fa-external-link-square-alt"></i></a> adipisicing elit. Quam nihil enim maxime corporis cumque totam aliquid nam sint inventore optio modi neque laborum officiis necessitatibus, facilis placeat pariatur! Voluptatem, sed harum pariatur adipisci voluptates voluptatum cumque, porro sint minima similique magni perferendis fuga! Optio vel ipsum excepturi tempore reiciendis id quidem? Vel in, doloribus debitis nesciunt fugit sequi magnam accusantium modi neque quis, vitae velit, pariatur harum autem a! Velit impedit atque maiores animi possimus asperiores natus repellendus excepturi sint architecto eligendi non, omnis nihil. Facilis, doloremque illum. Fugit optio laborum minus debitis natus illo perspiciatis corporis voluptatum rerum laboriosam.</p>

Here's how to reproduce the issue :

  1. Use the exampleSite from the repo.
  2. Add the fontawesome CDN to layouts/partials/head.html.
  3. Use a fontawesome icon within any paragraph.

Any advice on how to get rid of the extra spacing would be appreciated.

Thanks for the nice theme !

somratpro commented 3 years ago

Hello @cacsfre ,

Thanks for using our template, it would be great if you add a star to the repository.

cacsfre commented 3 years ago

Thanks @somratpro ! I just added a star. I see that you closed the issue, does it mean this is expected behaviour ?

somratpro commented 3 years ago

Hello @cacsfre

I am really sorry about that. I may be misunderstood your issue. I am reopening it now. Can you give me any live URL so I can check it out?

cacsfre commented 3 years ago

Live URL replicating the issue using the exampleSite. Please see the Paragraph section, that's the screenshot above. The code is here just in case.

somratpro commented 3 years ago

Hi @cacsfre

Try this <i class="fas fa-external-link-square-alt mb-0"></i>

cacsfre commented 3 years ago

That works, thank you @somratpro !