Setting a custom favicon overrides the theme's head.html, breaking the website

Isho312 commented 3 years ago

When setting a custom favicon as described in the docs, apparently, the custom head.html overrides the one provided by the theme, hence breaking the page, since no scripts are loaded.

Reproducing should be as follows:

hugo new site my_site
cd my_site
git clone https://github.com/themefisher/dot-hugo-documentation-theme.git themes/dot
Set the theme to dot in config.(toml|yml)
Add head.html under layouts/partials

This might be a problem with hugo's behavior, And the way in handles partials, by the way.

somratpro commented 3 years ago

Please don't add any header, customize the original one. thank you

Isho312 commented 3 years ago

That's what i did. Just wanted to point the behavior out.

Maybe this should be mentioned in the docs? That the theme looks for favicon.png and the relevant file (themes/dot/layouts/partials/head.html) needs to be updated in case the user wants to use another name?

somratpro commented 3 years ago

Hello @ishoantar We are going to update all our docs one by one.

gethugothemes / dot-hugo

Setting a custom favicon overrides the theme's head.html, breaking the website #166