search

gethugothemes / dot-hugo

Dot - Hugo Documentation Theme
https://gethugothemes.com/products/dot/?utm_source=dot_github&utm_medium=referral&utm_campaign=github_theme_about
MIT License
260 stars 148 forks source link

QUESTION: Add PDF export feature to upstream? #167

Closed jwflory closed 3 years ago

jwflory commented 3 years ago

Hi, we are using a forked version of this theme for the UNICEF Open Source Inventory. Recently, @Idadelveloper added a feature to export articles to PDFs in unicef/inventory-hugo-theme#9.

I opened this issue to see if this is a feature upstream is willing to support? If yes, we can bring that patch from our downstream fork and integrate it here upstream so all users of the theme can benefit. But before opening the Pull Request, we wanted to check if this is a wanted feature.

Thanks!

mehedi-sharif commented 3 years ago

Hello @jwflory Thanks for using our themes, It's a great honor for us. I saw in your repository you guys put our name , It would be a big achievement for us if you mention our credit in the website footer(not mandatory ). For the update please make a pull request. I think this will help others . Thanks

jwflory commented 3 years ago

Hi @mehedi-sharif, thanks for the reply and confirmation. @Idadelveloper opened #168 with the PDF export feature we implemented downstream. Let us know if you have feedback on that change or what we can do to prepare that patch for merging.

Also, I added an attribution to our site footer in the copyright field. See unicef/inventory@b4dbbb2b847e5838c260ffafa17b498ef28caaf6. 😄

jwflory commented 3 years ago

I noticed #168 was merged. Closing this issue, thanks for your support!