search

gethugothemes / hugo-modules

30+ Powerful Hugo Modules Created By Gethugothemes.
https://gethugothemes.com/hugo-modules
MIT License
108 stars 48 forks source link

Accordian doesnt display all code. #45

Closed jonniehack closed 6 months ago

jonniehack commented 7 months ago

When I moved from using "Collapse" to using "Accordion" correctly, I noticed that the chunk of code I placed into the new "Accordion" shortcode wasn't all displayed. Half the code was cut off. Can this be fixed?

tfsomrat commented 7 months ago

did you removed all codes from collapse completely? please attach a screenshot.

jonniehack commented 7 months ago

I believe I did remove all codes, yes. Did you forget to attach a screenshot? Could you instruct exactly what to remove?

tfsomrat commented 7 months ago

I want you to attach a screenshot of broken accordion. and also give me a repository link so that I can test it

jonniehack commented 7 months ago

I cant share the repo with you however this is my process.

Shortcode called like this

{{< tabs >}} {{< tab "1" >}} {{< accordion title="This is an accordion" >}}

LOTS OF CODE HERE, 82 lines of SQL

{{< /accordion >}} {{< /tab >}} {{< /tabs >}}

I have noticed, that once rendered half my code is missing, its as if the accordion has a set size. If I zoom out, I can see that more is displayed but its unreadable, zoom back in and more code is omitted.

tfsomrat commented 7 months ago

Is everything works if you don't use it inside the Tab?

jonniehack commented 7 months ago

No same behaviour outside of the tab

jonniehack commented 6 months ago

Have you been able to reproduce this?

tfsomrat commented 6 months ago

Hey @jonniehack, we have updated logbook hugo with for this module. please re-download it from your dashboard. thanks

jonniehack commented 2 months ago

I have updated Logbook and this module, and the problem remains for me. I do not belive this is fixed.

tfsomrat commented 2 months ago

Hey @jonniehack, this is the latest demo of Logbook theme, and everything is working as expected https://demo.gethugothemes.com/logbook/site/elements/

jonniehack commented 2 months ago

I have run npm run update-modules. It shows me I have version image Yet I am still having problems.
The demo elements page only has a couple of lines inside the accordians, this works fine. Have a go at dropping 50+ lines of codeblock inside an accordian and see if it still works. The limit on lines seems to be around 40 lines and no manner of updating Logbook or the modules seems to work. I have posts ready to publish but the limitation on accordians is frustrating. I have to shorten my code to get it to work I am unable to shorten one code block inside accordians to fewer than 44 lines and it does not render it all. it just it off completely so I still think this needs addressing. image

tfsomrat commented 2 months ago

Hey @jonniehack, thanks for your clear information. I have fixed it. please update your modules one more time, it should work perfectly.