search

gethypervisual / gridsome-plugin-netlify-cms

Gridsome.js plugin to include Netlify CMS
Other
15 stars 9 forks source link

Changed outDir to outputDir #16

Closed milos5593 closed 3 months ago

milos5593 commented 4 years ago

Per this pull request output directory will change from outDir to outputDir. This change will stop warnings during build time.

Soitora commented 3 years ago

Can this get merged @gethypervisual?

EDIT: @milos5593, shouldn't #L126 and #L129 also be renamed to outputDir? Running your branch as a dep still gives me error until I fixed those.

tobymarsden commented 3 years ago

@Soitora trying to figure out the backwards-compatibility implications. Any thoughts? Obviously prefer not to do Gridsome version sniffing but a major version bump isn't ideal either

Soitora commented 3 years ago

@Soitora trying to figure out the backwards-compatibility implications. Any thoughts? Obviously prefer not to do Gridsome version sniffing but a major version bump isn't ideal either

I think a minor/patch bump is enough, Gridsome changed outDir to outputDir in late 2019. The first release that used it was gridsome@0.7.13, so maybe set that as a dep for the version bump. There has been 10 releases of Gridsome since that point.

As I also mentioned, this PR didn't change all required lines, I could make another PR if you don't want to create one yourself