search

getify / CAF

Cancelable Async Flows (CAF)
MIT License
1.34k stars 46 forks source link

Use vanilla AbortController polyfill #9

Closed vkrol closed 5 years ago

vkrol commented 5 years ago

Fixes #7.

getify commented 5 years ago

Thank you!

Since node does not have AbortController yet, this change makes it a bit more cumbersome to use CAF since you need two requires instead of one. I was thinking maybe the node require could still bring in the polyfill automatically to ease that burden until node gets it natively.

I also think we should keep the phrase in the README that warns that if the polyfill is needed in an environment it means that any native APIs (like fetch) won't recognize and use it.

getify commented 5 years ago

I actually needed this update to do get the work I was doing in #8 functioning, so this was very timely, thanks! I did it slightly differently, but I appreciated you taking the lead to help get that polyfill fixed!

vkrol commented 5 years ago

I did it slightly differently, but I appreciated you taking the lead to help get that polyfill fixed!

You are welcome. Thank you!