getify / Functional-Light-JS

Pragmatic, balanced FP in JavaScript. @FLJSBook on twitter.
http://FLJSBook.com
Other
16.6k stars 1.96k forks source link

Copyediting suggestions for Chapter 3 #123

Closed jtassia closed 6 years ago

jtassia commented 6 years ago

Some queries/suggestions for Chapter 3...

Edit suggestion 1:

Original: "We will cover reduce(..) in Chapter 9, but briefly: it repeatedly calls its reducer function with two individual parameters, which we can now gather together:"

Suggestion: "We will cover reduce(..) more fully in Chapter 9; in short, it repeatedly calls its reducer function with two individual parameters, which we can now gather together:"

Edit suggestion 2:

Original: "A new inner function (called partiallyApplied(..) just for clarity) is created and returned, whose own arguments are gathered into an array called laterArgs."

Suggestion: "A new inner function (called partiallyApplied(..) just for clarity) is created and returned; the inner function's own arguments are gathered into an array called laterArgs."

Edit suggestion 3:

Original: "I've found it helps me tremendously to understand curried functions if I can unwrap them mentally as a series of nested functions like that."

Suggestion: "When trying to decipher curried functions, I've found it helps me tremendously if I can unwrap them mentally as a series of nested functions like that."

Edit suggestion 4:

Original: "That's decent, but it's also unfortunate that we kinda have to do add that"

Suggestion: "That's decent, but it's also unfortunate that it then obligates us to add that"

Edit suggestion 5:

Original: "So, this logic gets the 80% job done; it"

Suggestion: "So, this logic gets the job done 80% of the time; it"

Yes, I promise I've read the Contributions Guidelines

getify commented 6 years ago

Suggestion: "We will cover reduce(..) more fully in Chapter 9; in short, it repeatedly calls its reducer function with two individual parameters, which we can now gather together:"

Great!

Suggestion: "A new inner function (called partiallyApplied(..) just for clarity) is created and returned; the inner function's own arguments are gathered into an array called laterArgs."

Great!

Suggestion: "When trying to decipher curried functions, I've found it helps me tremendously if I can unwrap them mentally as a series of nested functions like that."

Great!

Suggestion: "That's decent, but it's also unfortunate that it then obligates us to add that"

Great!

Suggestion: "So, this logic gets the job done 80% of the time; it"

Great!

jtassia commented 6 years ago

Added to my branch!