search

getify / Functional-Light-JS

Pragmatic, balanced FP in JavaScript. @FLJSBook on twitter.
http://FLJSBook.com
Other
16.6k stars 1.96k forks source link

Copyediting suggestions for Chapter 4 #124

Closed jtassia closed 6 years ago

jtassia commented 6 years ago

Suggestions/queries for Chapter 4...

Edit suggestion 1:

Original: "Now, let's recall partialRight(..) from Chapter 3 to do something more interesting with composition."

Suggestion: "To do something more interesting with composition, let's use partialRight(..), which we first looked at in Chapter 3 ."

Edit suggestion 2:

Original: "so that each piece can be focused on independent of the other"

Suggestion: "so that it's possible to focus on each piece independently of the other"

Edit suggestion 3:

Original: "so they are separate and separately reason'able"

Suggestion: "so they are separate and can be reasoned about and processed separately"

Query 1:

Original: "...we'll call it filterWords(..) (see below)."

Query: OK to delete "(see below)" ? Doesn't seem necessary.

Query 2:

Original: "We'll be looking at the reduce(..) utility in detail later in the text, but"

Query: Can we point to a specific section/chapter here?

Query 3:

Original: "To do so, let's first to define"

Query: OK to delete "to"? Or is something missing here?

Yes, I promise I've read the Contributions Guidelines

getify commented 6 years ago

Suggestion: "To do something more interesting with composition, let's use partialRight(..), which we first looked at in Chapter 3 ."

Great!

Suggestion: "so that it's possible to focus on each piece independently of the other"

Great!

Suggestion: "so they are separate and can be reasoned about and processed separately"

I understand the reason for this change, and it's OK. I've always liked "reason'able" as short-hand for "able to be reasoned about" -- I think you may recall I've used that in previous books! -- but I'm not deeply attached to it. :)

Original: "...we'll call it filterWords(..) (see below)." Query: OK to delete "(see below)" ? Doesn't seem necessary.

Sure.

Original: "We'll be looking at the reduce(..) utility in detail later in the text, but" Query: Can we point to a specific section/chapter here?

Yep: "..utility in detail in Chapter 9, but.."

Original: "To do so, let's first to define" Query: OK to delete "to"? Or is something missing here?

Yep!

jtassia commented 6 years ago

Committed these to my branch. I'm OK with leaving "reason'able" as is :)