search

getify / Functional-Light-JS

Pragmatic, balanced FP in JavaScript. @FLJSBook on twitter.
http://FLJSBook.com
Other
16.6k stars 1.96k forks source link

Copyediting suggestions for Chapter 5 #125

Closed jtassia closed 6 years ago

jtassia commented 6 years ago

Suggested edits/queries for Chapter 5...

Edit suggestion 1:

Original: "But as we're trying to not just be academic in our study, but balanced with pragmatism, I think"

Suggestion: "However, because we're trying to avoid a strictly academic approach in favor of balancing it with pragmatism, I also think"

Query 1:

Original: "We'll discuss const in a later chapter."

Query: Can we point to a specific chapter here?

Query 2:

Kyle: I think this is the first time in the book I've noticed styling in headings (### this Revisited). Many books avoid this, but not all. Did we use styling in headings for YDKJS?

Yes, I promise I've read the Contributions Guidelines

bmacdonald-editor commented 6 years ago

DE butting in. I just took a took at "this & Object Prototypes." We didn't use code styling for this in any of the headings, although it was lower-case.

getify commented 6 years ago

Suggestion: "However, because we're trying to avoid a strictly academic approach in favor of balancing it with pragmatism, I also think"

Great!

Original: "We'll discuss const in a later chapter." Query: Can we point to a specific chapter here?

"We'll discuss const in Chapter 6."

I think this is the first time in the book I've noticed styling in headings (### this Revisited). Many books avoid this, but not all. Did we use styling in headings for YDKJS?

DE butting in. I just took a took at "this & Object Prototypes." We didn't use code styling for this in any of the headings, although it was lower-case.

I know we didn't do this for YDKJS, but I would kinda prefer to keep the formatting, as I find it useful to highlight syntax when it shows up in a heading.

jtassia commented 6 years ago

Added to my branch!