search

getify / Functional-Light-JS

Pragmatic, balanced FP in JavaScript. @FLJSBook on twitter.
http://FLJSBook.com
Other
16.6k stars 1.96k forks source link

Image tag not closing #180

Closed xorob0 closed 5 months ago

xorob0 commented 5 years ago

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line -- if you leave this line here, I'm going to assume you didn't actually read it).

Some reader don't like that the img tag are not closed. I would advise changing this : 

<p align="center">
    <img src="images/fig1.png" width="40%">
</p>

to this : 

<p align="center">
    <img src="images/fig1.png" width="40%"/>
</p>

on every images. I can do a the PR if you want me to, but maybe there is a reason for that that I do not understand.

getify commented 5 years ago

Some reader don't like that the img tag are not closed

Why?

xorob0 commented 5 years ago

If you try converting them to XHTML (for ePub for exemple) you need the self-closing tag because it is in the XHTML specifications it is needed (see https://www.w3schools.com/tags/tag_img.asp) My kobo e-reader really doesn't like that the tag is not closed and just skips the rest of the chapter...

getify commented 5 years ago

Interesting... I wonder why the epub that is generated from Leanpub works fine. Maybe they're correcting it.