search

getify / JSON.minify

Simple minifier for JSON to remove comments and whitespace
http://web.archive.org/web/20100629021329/http://blog.getify.com/2010/06/json-comments/
410 stars 102 forks source link

Set repo up on CI server #38

Closed nrktkt closed 3 years ago

nrktkt commented 8 years ago

Is there interest to have continuous integration set up for this repo? Different languages could have their own configurations and badges could be added to the README files. For maven in particular it would be useful to have CI set up to enable CD on PR merges.

pradyunsg commented 8 years ago

I'd say we should have this. I think @getify will have to enable it on this repository.

getify commented 8 years ago
  1. I'm not at all familiar with what the CI setup is? Would appreciate any pointers/links.
  2. Is this repo going to change enough to warrant that sort of process/setup overhead?
pradyunsg commented 8 years ago

I'm not at all familiar with what the CI setup is? Would appreciate any pointers/links.

It's pretty simple. I'm +5 for using Travis CI. It's free and really neat.

For setting that up, there's 2 steps.

  1. Click that Sign Up button on http://travis-ci.org. Creates an account at Travis CI.
  2. Flip the relevant switch over at https://travis-ci.org/profile/getify .

Then Travis watches pushes on branches and runs build/test jobs according to a .travis.yml file. @kag0 and I shall handle the .travis.yml file.

Is this repo going to change enough to warrant that sort of process/setup overhead?

I don't see it as an overhead but a helper, it's just saving us from doing a clone and running the tests on our machine. And then there's stuff

For Python, I'd love to get some CI. It'll make me feel a bit better to see that the tests pass on all versions from 2.5 to 3.5. :smile: For Java, the changes @kag0 suggests make more sense with a CI. (correct me if I'm wrong)

Plus we get good-looking badges and PR checks. :wink:

nrktkt commented 8 years ago

@pradyunsg beat me to the links :smile:

Travis is especially helpful for code that goes into central repositories (maven central or npm or whathaveyou) because it can be used to do CD, that way the central repo always has the latest version and one of the project maintainers doesn't have to do the update by hand.

pradyunsg commented 7 years ago

Ping @getify?