getify / JSON.minify

Simple minifier for JSON to remove comments and whitespace
http://web.archive.org/web/20100629021329/http://blog.getify.com/2010/06/json-comments/
410 stars 102 forks source link

add to pypi #43

Closed johanneswilm closed 7 years ago

johanneswilm commented 7 years ago

Hey, given that there was no action on the part of @pradyunsg over the past two years [1] and we badly needed this, I have published the python package to pypi [2]. In order to fulfill the pypi maintenance requirements, I really needed write access, so I did that out of our fork for now. However, I really don't have any shares in this package, so if @pradyunsg, @tobeycarman, @ronichoudhury or @getify want to take over package maintainership, just let me know and I will happily transfer it to you.

[1] https://github.com/getify/JSON.minify/issues/21 [2] https://pypi.python.org/pypi/JSON_minify

pradyunsg commented 7 years ago

Sorry; I completely lost track of this. Thanks for doing this @johanneswilm!

If you want it and @getify is fine with it, he can give you write access to the repo and you can maintain the package. Otherwise, I don't mind taking over the name and managing it. :)

johanneswilm commented 7 years ago

@pradyunsg Hey, yes, I would prefer for you to take over maintainership (I have too many other obligations already). If you give me your username on pypi, I can make the transfer.

pradyunsg commented 7 years ago

It's pradyunsg. :)

johanneswilm commented 7 years ago

@pradyunsg Ok, great, I have added you as a package owner. Feel free to remove me once you have everything set up.

pradyunsg commented 7 years ago

I'll do it in a few hours. :)

pradyunsg commented 7 years ago

Closing due to #45 and https://pypi.org/project/JSON_minify/ .

pradyunsg commented 7 years ago

Sorry for the delay. Got swept in other stuff.

pradyunsg commented 6 years ago

@johanneswilm Could you look at https://pypi.org/manage/project/JSON_minify/collaboration/ and verify if I'm a project owner?

johanneswilm commented 6 years ago

@pradyunsg you are a manager so that you can push out releases. I stay myself also just to ensure that releases really do happen given that there has been a history of updates not coming through.

pradyunsg commented 6 years ago

Mind making me an owner? =)

johanneswilm commented 6 years ago

I actually made you an owner first. But then when you didn't release for another 3 weeks even though the code was ready and had written in that there was no pypi package, I took that position again. Given that you apparently don't use the package on pypi yourself, I think this current setup is quite OK, don't you think? We are a bunch of different projects who need a package like this and had been waiting for years for a similar package to finally update to python 3, and the administrator just stopped reacting. So now it would be good to avoid having the same thing happen here.

pradyunsg commented 6 years ago

when you didn't release for another 3 weeks

I do this in my own free time. I did it when I found the free time to do so.

I think this current setup is quite OK, don't you think?

No, I don't. Anyway, if you want to stay on top of everything, you can just stay an owner. That said, I don't expect there to be any activity happening on this project and at the end of the day I don't really care enough to use my time to spend time elaborating the reasons for why I don't think so.

I'm happy to let you take over maintenance of the PyPI project and remove me as a collaborator.

johanneswilm commented 6 years ago

I do this in my own free time. I did it when I found the free time to do so.

Yes, and that's fine. But then you also surely understand that those who rely on this for something serious actually need to be able to make sure that the project doesn't just die on pypi, right?

I don't really care enough to use my time to spend time

Right. So that's another good reason why you probably shouldn't take full control of the package. You are welcome to continue as a manager though.

I'm happy to let you take over maintenance of the PyPI project and remove me as a collaborator.

Ok, I can continue to maintain it there as I have been doing, Let me know if you want to be added again.

pradyunsg commented 6 years ago

something serious actually need to be able to make sure that the project doesn't just die on pypi

Nope. It's easy enough to fork and maintain. I'd rather not digress though. :)

You are welcome to continue as a manager

I'll be happy to step down.

I can continue to maintain it there as I have been doing

👍

johanneswilm commented 6 years ago

Nope. It's easy enough to fork and maintain. I'd rather not digress though. :)

Right. But pypi maintainership is gone if the maintainer there is just unresponsive. Taht's what happened with the maintainer of a similar package. As for this package on pypi, the history is this:

  1. November 2014 requested ti to be packaged. Half a year later you said it would happen. Another half a year later you said you'd do it after your exams. We are now in December 2015. Two years later, fall 2017, I fixed the package and uploaded it to pypi and offered to you to let you take it over. You didn't take my fixes and instead wrote on the github page that the package is not on pypi (when it really was). When I intervened again, you finally uploaded your latest update to pypi another few weeks later.

So basically, I am a bit afraid of you just disappearing for a few years again. That's of course your right to do -- as you sid, you do this in your free time. It's just not acceptable for a production level project to depend on a maintainer who doesn't respond.That's why I will continue to have some control over the pypi package. I don;t understand why you need to be registered as package owner there when you don't really care enough to keep an updated package there.

pradyunsg commented 6 years ago

I don;t understand why you need to be registered as package owner there when you don't really care enough to keep an updated package there.

I don't. :)

getify commented 6 years ago

OK, seems like everything has been resolved. Locking this conversation so we don't digress any further.