getify / You-Dont-Know-JS

A book series on JavaScript. @YDKJS on twitter.
Other
178.87k stars 33.44k forks source link

Update ch2.md #1590

Closed Aegario closed 4 years ago

Aegario commented 4 years ago

I don't know if this is a correct way to put it, but I'm sure it was a bit hard for me to understand what you wrote

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

Specifically quoting these guidelines regarding typos:

Typos?

Please don't worry about minor text typos. These will almost certainly be caught during the editing process.

If you're going to submit a PR for typo fixes, please be measured in doing so by collecting several small changes into a single PR (in separate commits). Or, just don't even worry about them for now, because we'll get to them later. I promise.


Please type "I already searched for this issue":

Edition: (pull requests not accepted for previous editions)

Book Title:

Chapter:

Section Title:

Topic:

getify commented 4 years ago

I think your proposed change contradicts the intended meaning.

This sentence:

References (non-declarations) to variables/identifiers can be made from either the current scope, or any scope above/outside the current scope, but never to lower/nested scopes.

It means, and perhaps should be re-worded to say:

References (non-declarations) to variables/identifiers can be made for declarations from either the current scope, or any scope above/outside the current scope, but never to those from lower/nested scopes.

Aegario commented 4 years ago

Hi. Yes, I think the way you phrased it now is so much better :) Friday, 17 January 2020, 03:17AM +07:00 from Kyle Simpson notifications@github.com :

I think your proposed change contradicts the intended meaning. This sentence:

References (non-declarations) to variables/identifiers can be made from either the current scope, or any scope above/outside the current scope, but never to lower/nested scopes. It means, and perhaps should be re-worded to say: References (non-declarations) to variables/identifiers can be made for variables that are declared in either the current scope, or any scope above/outside the current scope, but never to those declared in lower/nested scopes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or unsubscribe .