search

getify / You-Dont-Know-JS

A book series on JavaScript. @YDKJS on twitter.
Other
178.28k stars 33.42k forks source link

Get-started: Rearrange TOC #1659

Closed hekkim closed 4 years ago

hekkim commented 4 years ago

Please type "I already searched for this issue": I already searched for this issue.

Edition: (1st or 2nd) 2nd

Book Title: Get-started

Chapter: TOC

Section Title: Iteration

Problem: Currently, Iteration is in between Prototype and Asking "Why"? in TOC like:

* Chapter 3: Digging To The Roots Of JS
    * Closure
    * `this` Keyword
    * Prototypes
    * Iteration
    * Asking "Why?"

However, an actual order in chapter 3 is like this.

* Chapter 3: Digging To The Roots Of JS
    * Iteration
    * Closure
    * `this` Keyword
    * Prototypes
    * Asking "Why?"

So, I think Iteration section in chapter 3 should be listed at first instead of Closure since the chapter begins with Iteration.

It's truly a minor issue, so if you want I can make a PR.

getify commented 4 years ago

Thanks for catching this. Yes a PR is appreciated. :)

getify commented 4 years ago

Fixed in #1661