search

getify / eslint-plugin-proper-arrows

ESLint rules to ensure proper arrow function definitions
MIT License
308 stars 14 forks source link

eslint v9 compatibility #37

Open lgenzelis opened 2 weeks ago

lgenzelis commented 2 weeks ago

The latest version of the plugin (11.0.3) is not compatible with eslint v9. Trying to use it results in the error TypeError: context.getScope is not a function.

According to the official eslint docs, this happens because

ESLint v9.0.0 introduces changes to the rules API that plugin rules use, which included moving some methods from the context object to the sourceCode object

getify commented 2 weeks ago

Yeah, I was aware of the breaking changes they made in v9, and how pretty much all my plugins were going to be broken.

I don't have enough time/justification to work on fixing those breaking changes, nor do I want to maintain separate versions for pre-9 and 9+.

I would accept contributions to do so, but the forked version support troubles me.

lgenzelis commented 1 week ago

What about creating a new major version that only supports eslint v9? Or is it your intention to continue to make changes to the plugin in the future, and you explicitly want to make those changes available to older eslint versions?

getify commented 1 week ago

I am not currently investing effort in this plugin, so fixing breaking changes that eslint decided to make (which I still sorta disagree with, but whatever) is not high on my list. But moreover, having then to need two separate projects (or branches or whatever) that have to be maintained --not just adding of features, but fixing bugs or security issues, etc -- is even more work, and even harder to justify.

I wouldn't block efforts by other contributors to do so, but it's just not something I have planned to prioritize here.

So, IOW... PRs accepted. ;-)