search

getindata / flink-http-connector

Http Connector for Apache Flink. Provides sources and sinks for Datastream , Table and SQL APIs.
Apache License 2.0
136 stars 39 forks source link

[HTTP-45] - Fix issue with not printing HttpRequest body/parameters for Lookup Source by Slf4JHttpLookupPostRequestCallback. #46

Closed kristoffSC closed 1 year ago

kristoffSC commented 1 year ago

Description

The Slf4JHttpLookupPostRequestCallback is an implementation of HttpPostRequestCallback interface for auditing http lookup queries and responses.

It turns out that Slf4JHttpLookupPostRequestCallback implementation does not print HttpReqeust body (json body or GET parameters).

This PR adds new object wrapper, HttpLookupSourceRequestEntry, that wraps original Java 11 HttpRequest and an actual request body or GET parameters.

Resolves https://github.com/getindata/flink-http-connector/issues/45

PR Checklist
github-actions[bot] commented 1 year ago
File Coverage [89.91%] :green_apple:
HttpLookupSourceRequestEntry.java 100% :green_apple:
RequestFactoryBase.java 100% :green_apple:
JavaNetHttpPollingClient.java 93.75% :green_apple:
Slf4JHttpLookupPostRequestCallback.java 79.69% :green_apple:
Total Project Coverage 94.14% :green_apple:
github-actions[bot] commented 1 year ago
File Coverage [89.91%] :green_apple:
HttpLookupSourceRequestEntry.java 100% :green_apple:
RequestFactoryBase.java 100% :green_apple:
JavaNetHttpPollingClient.java 93.75% :green_apple:
Slf4JHttpLookupPostRequestCallback.java 79.69% :green_apple:
Total Project Coverage 94.14% :green_apple: